test: Transfer to finalSystemOwner rather than SystemOwnerSafe#12116
Merged
test: Transfer to finalSystemOwner rather than SystemOwnerSafe#12116
Conversation
Contributor
Author
This was referenced Sep 25, 2024
maurelian
requested review from
Inphi and
mds1
and removed request for
a team and
Inphi
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
744233a to
cf61e6a
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
e1612b0 to
155c549
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
cf61e6a to
f5c3b57
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
5c97e66 to
9a3d8a1
Compare
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
f5c3b57 to
1a22337
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
a31d1b1 to
8e252e9
Compare
mds1
reviewed
Sep 25, 2024
mds1
approved these changes
Sep 25, 2024
Contributor
mds1
left a comment
mds1
left a comment
There was a problem hiding this comment.
This LGTM, but CI is failing—unsure if it's a flake or legit failure
Also cc @smartcontracts to make sure there's no reason we shouldn't be changing the FPACOPS scripts
maurelian
force-pushed
the
opcm/in-tests-2
branch
from
1a22337 to
f70779f
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
8e252e9 to
07688b6
Compare
Contributor
Author
Should be good now.
FWIW it's literally just a variable rename. But we revert the changes to those files if necessary. |
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
4f6dc93 to
7a46da7
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
2 times, most recently
from
f8f074b to
71a4ea3
Compare
maurelian
force-pushed
the
opcm/in-tests-3
branch
2 times, most recently
from
c05fc51 to
ba58e61
Compare
maurelian
commented
Sep 26, 2024
Contributor
Author
Merge activity
|
maurelian
force-pushed
the
opcm/in-tests-3
branch
from
ba58e61 to
88032de
Compare
This was referenced Sep 30, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…eum-optimism#12116) * test: Transfer to finalSystemOwner rather than SystemOwnerSafe * feat: Fix comment references to ProxyAdmin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: Transfer to finalSystemOwner rather than SystemOwnerSafe
test(deploy): Remove SystemOwnerSafe
Instead of deploying a SystemOwnerSafe at the start, then performing
all ProxyAdmin and other admin actions via that Safe, we now
simply setup the system using deploy (
msg.sender) and then transferto the
finalSystemOwnerat the end.